This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix: warning with default archive templates when queryId is missing #10596
Merged
dinhtungdu
merged 1 commit into
trunk
from
fix/default-catalog-template-missing-queryId
Aug 15, 2023
Merged
Fix: warning with default archive templates when queryId is missing #10596
dinhtungdu
merged 1 commit into
trunk
from
fix/default-catalog-template-missing-queryId
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release ZIP for this PR is accessible via:
TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
August 15, 2023 09:08
dinhtungdu
added
status: needs review
skip-changelog
PRs that you don't want to appear in the changelog.
focus: template
Related to API powering block template functionality in the Site Editor
block-type: product-query
Issues related to/affecting all product-query variations.
type: bug
The issue/PR concerns a confirmed bug.
labels
Aug 15, 2023
imanish003
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thank you so much for working on it 🙌🏻
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Aug 15, 2023
nielslange
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @dinhtungdu. The PR works as expected and I'll cherry-pick it into 10.9.0 after you merged it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block-type: product-query
Issues related to/affecting all product-query variations.
focus: template
Related to API powering block template functionality in the Site Editor
skip-changelog
PRs that you don't want to appear in the changelog.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10200 introduces a PHP warning for block themes using the default archive templates that indicate the
queryId
is missing. This PR fixes that warning by addingqueryId
to theProducts (Beta)
block in the blockifed archive templates.We need the
queryId
for the pagination to work, so we decided to include thequeryId
to the template file. Doing so is safe because we only includequeryId
inside templates, every newProducts (Block)
orQuery Loop
block will have a differentqueryId
autogenerated.Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
N/a
Changelog
N/a